[TG Mirror] Fixes Space Dragon Attacking [MDB IGNORE] #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ffmirrorbot[bot]](https://avatars.githubusercontent.com/in/391347?s=60&v=4){kind=small}
* Fixes Space Dragon Attacking (#78964) Fixes #78953 ## About The Pull Request Basically the gist is that Space Dragon's special attack code was on `AttackingTarget()` rather than whatever the hell simple animals controlled by clients use (I didn't bother enough to look into the chain to remember this). This was the complete wrong proc to use, and it NEVER got executed. Anyways, we just hook into the signal for whatever the simple animal proc is as well as clean up all the code, make everything pretty, and most importantly: MAKE THE DAMN CODE WORK ## Why It's Good For The Game Either someone did not test their code at all, or some weird esoteric change in the attack chain changed this somehow? I'm not sure when or why this happened but it is guaranteed to be fixed now. The code cleanup and tinkering I did means that it's gonna be about 10% easier to port this over to a basic mob eventually (not doing a full refactor when this shit is this broken, the code added here is modular enough to the point where it's plug-n-play). ## Changelog :cl: fix: Space Dragons can now, once again, tear down walls and eat corpses. They also have regained their special damage modifier when attacking mechs. /:cl: * Fixes Space Dragon Attacking --------- Co-authored-by: san7890 <the@san7890.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: ${this.url}
Original PR: (original url)
Fixes #78953
About The Pull Request
Basically the gist is that Space Dragon's special attack code was on
AttackingTarget()rather than whatever the hell simple animals controlled by clients use (I didn't bother enough to look into the chain to remember this). This was the complete wrong proc to use, and it NEVER got executed. Anyways, we just hook into the signal for whatever the simple animal proc is as well as clean up all the code, make everything pretty, and most importantly:MAKE THE DAMN CODE WORK
Why It's Good For The Game
Either someone did not test their code at all, or some weird esoteric change in the attack chain changed this somehow? I'm not sure when or why this happened but it is guaranteed to be fixed now.
The code cleanup and tinkering I did means that it's gonna be about 10% easier to port this over to a basic mob eventually (not doing a full refactor when this shit is this broken, the code added here is modular enough to the point where it's plug-n-play).
Changelog
🆑 san7890
fix: Space Dragons can now, once again, tear down walls and eat corpses. They also have regained their special damage modifier when attacking mechs.
/:cl: