[TG Mirror] Improved documentation and message for the dcs_check_list_arguments unit test. [MDB IGNORE] #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ffmirrorbot[bot]](https://avatars.githubusercontent.com/in/391347?s=60&v=4){kind=small}
…guments unit test. [MDB IGNORE] (#24338) * Improved documentation and message for the dcs_check_list_arguments unit test. (#78903) ## About The Pull Request I've been contacted recently by san7890 regarding an opened issue report about the aforementioned unit test. I've told them it's mainly an issue about the lack of clarity and the bad choice of words in both documentation and fail messages, and that I'd get to it soon. I don't repute myself a good writer. The renewed doc and messages may contain a few grammar issues, but I'm optimistic that it explains it way more thoroughfully than before. ## Why It's Good For The Game Better documentation for one of the few unit tests that might tell you to "fix" stuff you're not directly responsible of. Suggestions are welcome. This closes #78896. ## Changelog N/A * Improved documentation and message for the dcs_check_list_arguments unit test. --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: ${this.url}
Original PR: (original url)
About The Pull Request
I've been contacted recently by san7890 regarding an opened issue report about the aforementioned unit test. I've told them it's mainly an issue about the lack of clarity and the bad choice of words in both documentation and fail messages, and that I'd get to it soon.
I don't repute myself a good writer. The renewed doc and messages may contain a few grammar issues, but I'm optimistic that it explains it way more thoroughfully than before.
Why It's Good For The Game
Better documentation for one of the few unit tests that might tell you to "fix" stuff you're not directly responsible of. Suggestions are welcome. This closes #78896.
Changelog
N/A