-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed not using .G for g0, and not using thrusterPower for fuel use #2
Open
NathanKell
wants to merge
38
commits into
Ialdabaoth:master
Choose a base branch
from
NathanKell:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was checking for absence of a PROPELLANT node even when loading from persistence, which screwed things over bigtime.
*Added more checks for lacking-PROPELLANT, and copy flowMode too *fix chicknblender's bug re: sub-750m/s velocities (I double-applied frame correction) *Tweaked how fullThrust is handled *Updated readme.
Unity is BAD at joysticks; it seems to ignore deadzone. So you can get like 3% waver on the control actuation. This adds a clamp: if control actuation < 5%, ignore.
* Fix long-standing typo; needs to be AddValue not SetValue for non-PROPELLANT compatibility. * Now thrust is normalized, then scaled by thrusterPower. Also, precision is now always 10% thrust, not the lever arm stuff of Squad.
Fixes bug in thrust force, allows semi-fullThrust mode (clamp below which fullThrust doesn't engage).
thrusterPower was being used correctly. fixedDeltaTime wasn't.
* Removed input normalization. (normalized inputs results in incorrect thrust level and wreaks havoc on MechJeb)
Remove input normalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.