user is not able make transfer transaction withing same account #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjawaids
requested changes
Dec 15, 2024
| const srcAccountDropdown = document.getElementById('src_account_id'); | ||
| const destAccountDropdown = document.getElementById('dest_account_id'); | ||
|
|
||
| srcAccountDropdown.addEventListener('change', () => { |
There was a problem hiding this comment.
I haven't tested it yet but it seems if user has accounts CASH, BANK, and MOBILE for example, and user selects CASH in source then it would be removed from destination account which is fine, but if user selects BANK in the destination account then it will be removed from the source account which is incorrect because what if user wants to change their selection in source account to BANK? They won't be able to do that easily. Removing only from destination would be sufficient and changing source would do the trick.
mjawaids
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.