Prometheus config fallbacks #115
Open
+211
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrauh01
force-pushed
the
prometheus-config
branch
from
a2ae88f
to
768e5c9
Compare
lippserd
requested changes
Aug 22, 2024
pkg/metrics/config.go
Outdated
| } | ||
|
|
||
| stmt, _ := db.BuildUpsertStmt(&schemav1.Config{}) | ||
| if _, err := db.NamedExecContext(ctx, stmt, configPairs); err != nil { |
There was a problem hiding this comment.
Do the INSERTs/UPDATEs in a serializable transaction. Think about why this is a good idea and whether the other side should do that too. See here for how we do it in Icinga DB: https://github.com/Icinga/icingadb/blob/main/pkg/icingadb/ha.go#L289.
As this is a pattern that we are now using a second time, you should consider how this could be done using a function.
lippserd
force-pushed
the
notifications-integration
branch
2 times, most recently
from
e4223a9
to
e9917b7
Compare
jrauh01
force-pushed
the
prometheus-config
branch
from
8435531
to
72fe379
Compare
jrauh01
force-pushed
the
prometheus-config
branch
from
72fe379
to
ccb4b0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more options to set Prometheus config: