[⚠️ Please don't merge yet! ⚠️] Don't pass -NoProfile, -NoLogo, -ExecutionPolicy and -C if $ifw_api_port$ is set

[Al2Klimov]

As discussed in

• Built-in check command: ifw-api icinga2#9062

TODO

• test @Al2Klimov

[Al2Klimov]

Walked through Icinga/icinga2#9062 (comment) again. Of course I chose the latest Icinga 2 Windows MSI mentioned in that PR. After the latter I patched the local file like here. Now, after Write-IcingaFrameworkCodeCache, Get-IcingaCheckCommandConfig output changed exactly like the PR diff. So far, so good.

[Al2Klimov]

Successfully finished the walkthrough. I.e. everything works, w/ and w/o ifw-api.

[LordHepipud]

Thanks for the PR. Can you please add the following to the changelog.md for v1.11.0 under the Enhancements section and sqush it to one commit:

### Enhancements

* [#629](https://github.com/Icinga/icinga-powershell-framework/pull/629) Adds support for Icinga 2.14 direct API call to Icinga for Windows

[LordHepipud]

One side note: You will also have to edit the plain Icinga configuration setting at line 635 and beyond. Can you please update the PR accordingly?

[Al2Klimov]

I must be blind and/or stupid not to find the changelog:

➜  icinga-powershell-framework git:(ifw-api) ls
LICENSE                          cache                            icinga-powershell-framework.psd1
PSScriptAnalyzerSettings.psd1    certificate                      icinga-powershell-framework.psm1
README.md                        custom                           lib
RoleCapabilities                 doc                              templates
➜  icinga-powershell-framework git:(ifw-api) find . -iname changelog.md
➜  icinga-powershell-framework git:(ifw-api)

[Al2Klimov]

You can commit it as second commit and thereby get the credits for it.

[Al2Klimov]

⚠️ Please don't merge yet! ⚠️

We've discovered more problems this thing solely can't cope with!

Maybe this will even become unnecessary.

@LordHepipud

[Al2Klimov]

This has never actually worked, see discussion since Icinga/icinga2#9062 (comment)