Skip to content

Fix: Return value for "Agent" component installation failure #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Fix: Return value for "Agent" component installation failure #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eed1efa
Fixes return value for "Agent" component installation failure
LordHepipud Feb 7, 2025
6b61ab1
Updates changelog
LordHepipud Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/100-General/10-Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic

[Issues and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/38)

### Bugfixes

* [#787](https://github.com/Icinga/icinga-powershell-framework/pull/787) Fixes the return value in case the `Agent` component could not be installed from `$FALSE` to `null`

## 1.13.2 (2025-02-03)

[Issues and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/40)
Expand Down
2 changes: 1 addition & 1 deletion lib/core/repository/Install-IcingaComponent.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ function Install-IcingaComponent()

if ($InstallProcess.ExitCode -ne 0) {
Write-IcingaConsoleError -Message 'Failed to install component "agent": {0}{1}' -Objects $InstallProcess.Message, $InstallProcess.Error;
return $FALSE;
return;
}

$Global:Icinga.Protected.Environment.'Icinga Service'.Present = $TRUE;
Expand Down