Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adds support for Invoke-IcingaCheckService to report not found services as CRITICAL instead of UNKNOWN #378

Conversation

LordHepipud
Copy link
Collaborator

@LordHepipud LordHepipud commented Jan 8, 2024

Allows users to change the plugin output behavior for Invoke-IcingaCheckService, to report CRITICAL instead of UNKNOWN in case a service could not be found on the system

Fixes #387

@cla-bot cla-bot bot added the cla/signed label Jan 8, 2024
@LordHepipud LordHepipud self-assigned this Jan 8, 2024
@LordHepipud LordHepipud added the enhancement New feature or request label Jan 8, 2024
@LordHepipud LordHepipud added this to the v1.12.0 milestone Jan 8, 2024
@LordHepipud LordHepipud force-pushed the feature/allow_service_plugin_to_report_not_found_as_critical branch from 00fda6c to 16d74ed Compare January 8, 2024 14:23
@drapiti
Copy link

drapiti commented Mar 12, 2024

Just a note, in our environment which is over 10000 windows systems, if a specific service is not present on a certain server than the check should remain ok. Not unknown and not critical. It would be impracticable to maintain every specific sevice for each single server.
So please allow this behaviour to be configurable. At the moment we have customized the check to cater for this.

@LordHepipud LordHepipud force-pushed the feature/allow_service_plugin_to_report_not_found_as_critical branch 3 times, most recently from c9ffcb9 to 9f1bf77 Compare March 25, 2024 10:51
@LordHepipud LordHepipud force-pushed the feature/allow_service_plugin_to_report_not_found_as_critical branch from 9f1bf77 to be4cfbf Compare March 25, 2024 10:53
@LordHepipud LordHepipud merged commit 1a186d2 into master Mar 25, 2024
1 check passed
@LordHepipud LordHepipud deleted the feature/allow_service_plugin_to_report_not_found_as_critical branch March 25, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoke-IcingaCheckService - Add option to define OK state if service not found
2 participants