Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Host-/Servicegroup grid views #355

Merged
merged 11 commits into from
Jun 20, 2023
Merged

Add Host-/Servicegroup grid views #355

merged 11 commits into from
Jun 20, 2023

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented Sep 15, 2021 •
edited by raviks789
Loading

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 15, 2021
@yhabteab yhabteab self-assigned this Sep 15, 2021
@yhabteab yhabteab added area/ui Affects the user interface enhancement New feature or improvement labels Sep 15, 2021
@yhabteab yhabteab force-pushed the feature/add-host-servicegroup-grid-views-221 branch 4 times, most recently from a415d36 to d85c089 Compare September 16, 2021 15:03
@yhabteab yhabteab force-pushed the feature/add-host-servicegroup-grid-views-221 branch from d85c089 to 105b5d2 Compare September 17, 2021 07:21
@raviks789 raviks789 force-pushed the feature/add-host-servicegroup-grid-views-221 branch 8 times, most recently from 95b8962 to 62020cf Compare June 5, 2023 11:32
@raviks789 raviks789 self-assigned this Jun 5, 2023
@raviks789 raviks789 force-pushed the feature/add-host-servicegroup-grid-views-221 branch 3 times, most recently from 49cf8d0 to 1ab769d Compare June 5, 2023 11:43
@raviks789 raviks789 requested a review from flourish86 June 5, 2023 12:46
flourish86
flourish86 previously approved these changes Jun 5, 2023
View reviewed changes
@raviks789 raviks789 force-pushed the feature/add-host-servicegroup-grid-views-221 branch from 1ab769d to 6cad3a8 Compare June 5, 2023 13:58
nilmerg
nilmerg requested changes Jun 7, 2023
View reviewed changes
application/controllers/HostgroupsController.php Outdated Show resolved Hide resolved
application/controllers/HostgroupsController.php Outdated Show resolved Hide resolved
application/controllers/ServicegroupsController.php Outdated Show resolved Hide resolved
application/controllers/HostgroupsController.php Outdated Show resolved Hide resolved
application/controllers/HostgroupsController.php Outdated Show resolved Hide resolved
application/controllers/ServicegroupsController.php Outdated Show resolved Hide resolved
application/controllers/ServicegroupsController.php Outdated Show resolved Hide resolved
library/Icingadb/Web/Controller.php Outdated Show resolved Hide resolved
library/Icingadb/Web/Control/GridViewModeSwitcher.php Outdated Show resolved Hide resolved
library/Icingadb/Web/Controller.php Show resolved Hide resolved
@nilmerg nilmerg added this to the 1.1.0 milestone Jun 7, 2023
@nilmerg nilmerg removed the area/ui Affects the user interface label Jun 7, 2023
@raviks789 raviks789 force-pushed the feature/add-host-servicegroup-grid-views-221 branch 5 times, most recently from bc55feb to 9ce5b57 Compare June 15, 2023 14:17
nilmerg
nilmerg requested changes Jun 20, 2023
View reviewed changes
library/Icingadb/Web/Control/ViewModeSwitcher.php Outdated Show resolved Hide resolved
public/css/widget/table-layout.less Outdated Show resolved Hide resolved
public/css/widget/table-layout.less Outdated Show resolved Hide resolved
public/css/widget/table-layout.less Outdated Show resolved Hide resolved
public/css/widget/table-layout.less Show resolved Hide resolved
public/css/list/item-table.less Outdated Show resolved Hide resolved
library/Icingadb/Widget/ItemTable/HostgroupGridCell.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/ItemTable/ServicegroupGridCell.php Show resolved Hide resolved
@raviks789 raviks789 force-pushed the feature/add-host-servicegroup-grid-views-221 branch 2 times, most recently from 84c70cd to 62e0f9e Compare June 20, 2023 09:28
@raviks789 raviks789 requested a review from nilmerg June 20, 2023 09:49
@raviks789 raviks789 force-pushed the feature/add-host-servicegroup-grid-views-221 branch from 62e0f9e to 57117c8 Compare June 20, 2023 09:50
nilmerg
nilmerg requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table layout is broken now

@raviks789 raviks789 force-pushed the feature/add-host-servicegroup-grid-views-221 branch from 57117c8 to 0cfecd3 Compare June 20, 2023 11:01
@raviks789 raviks789 requested a review from nilmerg June 20, 2023 11:03
nilmerg
nilmerg reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now. Thanks. Though, please rebase.

yhabteab and others added 11 commits June 20, 2023 13:39
@yhabteab @raviks789
Introduce Host-/Servicegroup grid action
ff7acb2
@yhabteab @raviks789
Introduce base group grid cell widget
f012f0c
@yhabteab @raviks789
Introduce Host/Servicegroup grid cell class
2dec524
@yhabteab @raviks789
Controller: Set redirectUrl to grid action when rendering `Host/Servi…
b7c19c5 
…cegroups` & switching to minimal
@yhabteab @raviks789
CSS: Cherry-pick group grid styles from monitoring
7e0956f
@raviks789
Order HostGroup/ServiceGroup by severity for grid list view
acccbcb
@raviks789
Add GridViewModeSwitcher to toggle between list and grid view
9a409f0 
Host and service groups need to toggle between grid and list view.
Hence, a new view mode switcher for this case has been created.
@raviks789
Use GridViewModeSwitcher for host and service groups
cc02853 
host and service groups need `GridViewModeSwitcher` to toggle between
list and grid view.
@raviks789
Delete the grid widget
6bd58e9 
The newly built `BaseTableRowItem` will be used for `HostgroupGridCell` and
`ServicegroupGridCell`.
@raviks789
Use BaseTableRowItem for HostgroupGridCell and `ServicegroupGridC…
b1654ee 
…ell`
@raviks789
Separate grid and table layout styles from item-table
7e746e2
@raviks789 raviks789 force-pushed the feature/add-host-servicegroup-grid-views-221 branch from 0cfecd3 to 7e746e2 Compare June 20, 2023 11:40
@raviks789 raviks789 requested a review from nilmerg June 20, 2023 11:42
@nilmerg nilmerg merged commit 1756065 into master Jun 20, 2023
@nilmerg nilmerg deleted the feature/add-host-servicegroup-grid-views-221 branch June 20, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviks789 raviks789 raviks789 left review comments

@nilmerg nilmerg nilmerg approved these changes

@flourish86 flourish86 flourish86 left review comments

Assignees

@raviks789 raviks789

@yhabteab yhabteab

Labels
area/view Affects an entire view cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Host- and Servicegroup grid views
4 participants
@yhabteab @flourish86 @nilmerg @raviks789