Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide reporting hook for single host/service #804

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

sukhwinder33445
Copy link
Contributor

resolves #781

…lural`

- Because these classes are used for `(Hosts|Services)DetailExtensionHook`
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 14, 2023
@sukhwinder33445 sukhwinder33445 self-assigned this Jul 14, 2023
@sukhwinder33445 sukhwinder33445 force-pushed the provide-reporting-hook-for-single-host-service branch 2 times, most recently from 4bee568 to 94ea92b Compare July 14, 2023 11:49
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please build the filters using ipl-stdlib and ipl-web's QueryString, not sprintf.

library/Icingadb/ProvidedHook/CreateServiceSlaReport.php Outdated Show resolved Hide resolved
@nilmerg nilmerg modified the milestone: 1.1.0 Jul 17, 2023
@sukhwinder33445 sukhwinder33445 force-pushed the provide-reporting-hook-for-single-host-service branch from 94ea92b to 08870a0 Compare July 17, 2023 13:36
@nilmerg nilmerg removed the request for review from yhabteab July 18, 2023 08:41
@nilmerg nilmerg merged commit 286ab98 into master Jul 18, 2023
@nilmerg nilmerg deleted the provide-reporting-hook-for-single-host-service branch July 18, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide create report actions for a single host/service
2 participants