Add base target _main to list controllers (#209)

Icinga · Oct 17, 2023 · 25c4b9b · 25c4b9b
2 parents 6af246f + 266139b
commit 25c4b9b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/application/controllers/ReportsController.php b/application/controllers/ReportsController.php
@@ -24,7 +24,6 @@ class ReportsController extends Controller
     public function indexAction()
     {
         $this->createTabs()->activate('reports');
-        $this->getTabs()->getAttributes()->set('data-base-target', '_main');
 
         if ($this->hasPermission('reporting/reports')) {
             $this->addControl(

diff --git a/application/controllers/TemplatesController.php b/application/controllers/TemplatesController.php
@@ -50,7 +50,6 @@ public function indexAction()
 
         $this->addControl($sortControl);
 
-
         $tableRows = [];
 
         /** @var Model\Template $template */

diff --git a/library/Reporting/Model/Timeframe.php b/library/Reporting/Model/Timeframe.php
@@ -33,6 +33,11 @@ public function getColumns()
         ];
     }
 
+    public function getDefaultSort(): string
+    {
+        return 'name';
+    }
+
     public function createBehaviors(Behaviors $behaviors)
     {
         $behaviors->add(new MillisecondTimestamp([

diff --git a/library/Reporting/Web/ReportsTimeframesAndTemplatesTabs.php b/library/Reporting/Web/ReportsTimeframesAndTemplatesTabs.php
@@ -14,6 +14,7 @@ trait ReportsTimeframesAndTemplatesTabs
     protected function createTabs()
     {
         $tabs = $this->getTabs();
+        $tabs->getAttributes()->set('data-base-target', '_main');
 
         $tabs->add('reports', [
             'title' => $this->translate('Show reports'),