Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support local_video_server #110

Merged
merged 15 commits into from
Jan 21, 2025
Merged

support local_video_server #110

merged 15 commits into from
Jan 21, 2025
+179 −0

Conversation

cutsea110
Copy link
Contributor

@cutsea110 cutsea110 commented Jan 17, 2025 •
edited
Loading

Check list

  • I wrote CHANGELOG.md if the pull request adds/modifies features.

Summary

  • LocalVideoServer を追加しました

@cutsea110 cutsea110 force-pushed the feature/localvideocast branch 8 times, most recently from 0ee328c to b0c129e Compare January 17, 2025 05:56
@cutsea110 cutsea110 force-pushed the feature/localvideocast branch 2 times, most recently from a06991f to 53ce9b0 Compare January 17, 2025 07:19
@cutsea110 cutsea110 force-pushed the feature/localvideocast branch from 53ce9b0 to d2d4223 Compare January 17, 2025 07:43
@cutsea110 cutsea110 force-pushed the feature/localvideocast branch from 06a4226 to e0ff049 Compare January 17, 2025 08:01
cutsea110
cutsea110 commented Jan 17, 2025
View reviewed changes
tests/test_import.py
@@ -5,6 +5,8 @@
"from_, import_",
[
("actfw_core", "Application"),
("actfw_core", "CommandServer"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これはついで。(参照実装なので通るのを確認したくもあった)

@cutsea110 cutsea110 changed the title Feature/localvideocast support local_video_server Jan 17, 2025
@cutsea110 cutsea110 force-pushed the feature/localvideocast branch from 2c64a83 to e0ff049 Compare January 17, 2025 08:49
@cutsea110 cutsea110 marked this pull request as ready for review January 17, 2025 09:24
@cutsea110 cutsea110 requested review from amutake and umadein and removed request for amutake and umadein January 17, 2025 09:25
@cutsea110
Copy link
Contributor Author

  • quality を Literal にするのは出来なかったのでお願いしたいです!
  • app-examples/local_video_server の方で動作確認済です!
  • version は 2.10.0rc1 を付けているので、Literal の後で消すか Bump 時に付け直してください。次は 2.10.0 です!

@amutake
Copy link
Member

amutake commented Jan 20, 2025

quality については https://stackoverflow.com/a/70243011 の方法で 1 から 100 の Literal にするのはエラーになってしまった、かつ mypy は大規模なリテラル型を効率的に扱うのは難しいらしく、代替案としてはカスタムクラスを作るか pydantic を新たに導入するかになりそこまではしたくないので諦める形としたいです

@amutake amutake requested review from umadein and amutake January 20, 2025 21:30
@amutake
Copy link
Member

amutake commented Jan 21, 2025

@umadein レビューどんな感じでしょうか？あと1時間でリリース作業と app-examples の方の変更もやりたく…

@umadein
Copy link
Contributor

umadein commented Jan 21, 2025

@amutake
すみません、やります🙏
最悪リリースは私やります！

umadein
umadein approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@umadein umadein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amutake amutake merged commit aa9c485 into master Jan 21, 2025
10 checks passed
@amutake amutake deleted the feature/localvideocast branch January 21, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amutake amutake amutake left review comments

@umadein umadein umadein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cutsea110 @amutake @umadein