Skip to content

Missing "x5c" key for serialized ECKey and others. #165

Open
@sallner

Description

@sallner

Hello and thanks for the good work on this library.

While I was using it I came across one inconsistency with respect to handling x5c certificates on various asymmetric keys. It looks that in principle

JWK.__init__(self, kty, alg, use, kid, x5c, x5t, x5u, **kwargs)
will store the x5c on the key instance but only for RSAKeys this is also included in serialize().
if self.x5c:
res["x5c"] = [as_unicode(x) for x in self.x5c]

Is this intentional? In principal I see no problem, that also other asymmetric keys could have a x5c certificate attached to it, in particular the ECKey.
Would you consider this a reasonable change?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions