Skip to content

Salt length #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Salt length #179

wants to merge 6 commits into from

Conversation

rohe
Copy link
Contributor

@rohe rohe commented May 7, 2025

The PSS code in this package was based on the example in the cryptography documentation.
Unfortunately the documentation is not absolute correct. It works as it is but not when verifying a signature that some other library in some other language has produced.

@rohe rohe requested a review from a team as a code owner May 7, 2025 15:33
@rohe rohe requested a review from jschlyter May 7, 2025 15:33
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.44%. Comparing base (2b735fe) to head (b0f39a5).

Files with missing lines Patch % Lines
src/cryptojwt/key_bundle.py 14.28% 4 Missing and 2 partials ⚠️
src/cryptojwt/key_jar.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   76.45%   76.44%   -0.02%     
==========================================
  Files          44       44              
  Lines        4489     4495       +6     
  Branches      841      844       +3     
==========================================
+ Hits         3432     3436       +4     
  Misses        777      777              
- Partials      280      282       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jschlyter
jschlyter previously approved these changes May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants