Skip to content

Better exception handling for missing keys and issuers #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 24, 2020
Merged

Better exception handling for missing keys and issuers #51

merged 7 commits into from
Jun 24, 2020

Conversation

jschlyter
Copy link
Collaborator

  • raise better exceptions when keys and issuers are not found
  • still try to be backwards compatible (tests mostly agrees that we are)

@jschlyter jschlyter requested a review from rohe June 24, 2020 15:34
@jschlyter jschlyter self-assigned this Jun 24, 2020
rohe
rohe approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@rohe rohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jschlyter jschlyter merged commit e8789c2 into IdentityPython:develop Jun 24, 2020
@jschlyter jschlyter deleted the unknown_issuer branch June 24, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohe rohe rohe approved these changes

Assignees

@jschlyter jschlyter

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschlyter @rohe