Changes as an effect of changing persistent storage model. #80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 78.39% 77.16% -1.23%
==========================================
Files 41 41
Lines 4193 4283 +90
Branches 808 822 +14
==========================================
+ Hits 3287 3305 +18
- Misses 648 716 +68
- Partials 258 262 +4
Continue to review full report at Codecov.
|
pyproject.toml
Outdated
| @@ -22,7 +22,7 @@ exclude_lines = [ | |||
|
|
|||
| [tool.poetry] | |||
| name = "cryptojwt" | |||
| version = "1.4.1" | |||
| version = "1.4.2" | |||
There was a problem hiding this comment.
This seems like a minor version bump, 1.5.0 perhaps?
src/cryptojwt/key_bundle.py
Outdated
| @@ -751,7 +751,7 @@ def difference(self, bundle): | |||
|
|
|||
| return [k for k in self._keys if k not in bundle] | |||
|
|
|||
| def dump(self): | |||
| def dump(self, cutoff: Optional[list] = None): | |||
There was a problem hiding this comment.
Somewhat confusing attribute name (at least for me). Perhaps excluded_attrs is better?
The type should be Optional[List[str]] I think (I assume attribute names are strings)
There was a problem hiding this comment.
Horticultural term :-)
Imaging that you are dealing with something that looks like a tree and there are branches you don't want to be included so you cut them off.
Yes, attribute names are strings.
src/cryptojwt/key_issuer.py
Outdated
| """ | ||
| Returns the content as a dictionary. | ||
|
|
||
| :param exclude: Issuer that should not be include in the dump |
There was a problem hiding this comment.
exclude_issuer(perhaps make itexclude_issuersand aOptional[List[str]]to allow multiple issuers to be excluded?)exclude_attrs(orexclude_attributes)
| @@ -32,7 +32,6 @@ def __init__( | |||
| remove_after=3600, | |||
| httpc=None, | |||
| httpc_params=None, | |||
| storage=None, | |||
There was a problem hiding this comment.
Can we assume that no one (excluding closing family) has used the storage class yet?
src/cryptojwt/key_bundle.py
Outdated
| @@ -751,7 +752,7 @@ def difference(self, bundle): | |||
|
|
|||
| return [k for k in self._keys if k not in bundle] | |||
|
|
|||
| def dump(self): | |||
| def dump(self, exclude_attribute: Optional[List[str]] = None): | |||
src/cryptojwt/key_issuer.py
Outdated
| @@ -350,16 +352,17 @@ def __len__(self): | |||
| nr += len(kb) | |||
| return nr | |||
|
|
|||
| def dump(self, exclude=None): | |||
| def dump(self, exclude_attribute: Optional[List[str]] = None) -> dict: | |||
src/cryptojwt/key_jar.py
Outdated
| """ | ||
| Returns the key jar content as dictionary | ||
|
|
||
| :param exclude_issuer: A list of issuers you don't want included. |
Instead of having class instances doing the storage we instead want to put the burden on the frontend.
This will among other things decrease the number of DB calls significantly.
The frontend will have the methods dump, flush and load to store, clear and retrieve state.