This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Null value #57
Merged
Null value #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
reviewed
Feb 19, 2022
src/oidcmsg/configure.py
Outdated
| @@ -105,12 +105,12 @@ def __getattr__(self, item, default=None): | |||
| return default | |||
|
|
|||
| def __setattr__(self, key, value): | |||
| if key in self: | |||
| if key in self and self.key is not None: | |||
There was a problem hiding this comment.
... or, consider if usefull, self.key not in (None, "", {}, [] ...)
self.key would only be None?
peppelinux
approved these changes
Feb 19, 2022
|
Roland can we have v1.6.0 instead of 1.6.1? |
|
Yes |
nsklikas
approved these changes
Feb 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an attribute in the Configuration class to be set to None before assigning a non-None value.