Update setup.rst #307
Merged
Update setup.rst #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document has something wrong in PySAML2 specific files and configuration: https://djangosaml2.readthedocs.io/contents/setup.html#pysaml2-specific-files-and-configuration The example put `allow_unknown_attributes` in `service.sp`, however, in pysaml2, `allow_unknown_attributes` is at root level, since `allow_unknown_attributes` was put at `COMMON_ARGS`: https://github.com/IdentityPython/pysaml2/blob/master/src/saml2/config.py
|
Thank you @oakmegaeddie I merge it directly to master branch since this PR doesn't made any changes to the current release but only in the official documentation thank you, really appreciate you help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document has something wrong in PySAML2 specific files and configuration:
https://djangosaml2.readthedocs.io/contents/setup.html#pysaml2-specific-files-and-configuration
The example put
allow_unknown_attributesinservice.sp, however, in pysaml2,allow_unknown_attributesis at root level, sinceallow_unknown_attributeswas put atCOMMON_ARGS:https://github.com/IdentityPython/pysaml2/blob/master/src/saml2/config.py