Allow overriding SameSite value for session cookie #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RouganStriker
force-pushed
the
override_samesite_value
branch
from
c631047 to
767b483
Compare
|
good one, it seems really reasonable to me please commit a version change to 1.6.0, then I'll merge it on master branch and do a new release |
Bumped version to 1.6.0 |
peppelinux
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing against a dev instance without TLS enabled, because browsers are requiring SameSite=None to be paired with Secure=True, the session cookie will not be set and causes SSO issues.
This change allows the SameSite value to be customized via a settngs value.