Swap pycrypto* for pyca/cryptography #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 doubleplusgood |
jharbott
reviewed
Jan 12, 2017
src/saml2/cert.py
Outdated
| """ | ||
| for tmp_cert_str in cert_chain_str_list: | ||
| valid, message = self.verify(tmp_cert_str, cert_str) | ||
| print("validated") |
There was a problem hiding this comment.
This looks strange, leftover from testing?
spaceone
reviewed
Jan 12, 2017
| assert not OpenSSLWrapper().certificate_not_valid_yet(cert) | ||
| return True | ||
| cert = crypto.load_certificate(crypto.FILETYPE_PEM, cert_str) | ||
| assert cert.has_expired() == 0 |
Contributor
There was a problem hiding this comment.
assertion in production code might be optimized out.
Author
There was a problem hiding this comment.
I'm simply replacing an existing assertion. I expect @rohe already knows that about this code.
spaceone
reviewed
Jan 12, 2017
| cert_algorithm = cert.get_signature_algorithm() | ||
| if six.PY3: | ||
| cert_algorithm = cert_algorithm.decode('ascii') | ||
| cert_str = cert_str.encode('ascii') |
Contributor
There was a problem hiding this comment.
what if the certificate contains umlauts e.g. "ä"? Are they encoded in a special format?
Contributor
There was a problem hiding this comment.
cert_str is a PEM formatted string here, which is guaranteed to be ascii. The requirement for this is because load_pem_x509_certificate takes bytes, not text.
sigmavirus24
force-pushed
the
move-to-cryptography
branch
from
97dfc5b to
afdf5b4
Compare
pyOpenSSL is already a dependency and pyOpenSSL uses cryptography. This also reduces the complexity of the code significantly in several places (and removes the need to directly manipulate asn1). A future PR could remove pyOpenSSL entirely as all the cert behavior is supported directly by cryptography.
|
Not that my vote has any weight here, but 👍 |
Author
|
On January 24, 2017 11:21:35 AM CST, Roland Hedberg ***@***.***> wrote:
Merged #385.
Thanks for merging!
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyOpenSSL is already a dependency and pyOpenSSL uses cryptography.
This also reduces the complexity of the code significantly in several
places (and removes the need to directly manipulate asn1). A future
PR could remove pyOpenSSL entirely as all the cert behavior is supported
directly by cryptography.