Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Destination #782

Closed
wants to merge 2 commits into from
Closed

Validate Destination #782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a50db00
fix: Destination missing or unvalued. Fixes: https://github.com/Ident…
peppelinux Mar 20, 2021
b757975
fix: Destination must be validated only if present
peppelinux Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/saml2/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,12 +408,13 @@ def _verify(self):
else:
raise RequestVersionTooHigh()

if self.asynchop:
if (
self.response.destination
and self.response.destination not in self.return_addrs
):
logger.error("%s not in %s", self.response.destination, self.return_addrs)
destination = self.response.destination
if self.asynchop and destination:
# Destination must be present
if destination not in self.return_addrs:
logger.error(
f"{destination} not in {self.return_addrs}"
)
return None

valid = self.issue_instant_ok() and self.status_ok()
Expand Down Expand Up @@ -1116,7 +1117,7 @@ def session_info(self):
raise StatusInvalidAuthnResponseStatement(
"The Authn Response Statement is not valid"
)

def __str__(self):
return self.xmlstr

Expand Down