Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate assertion format #785

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

peppelinux
Copy link
Member

@peppelinux peppelinux commented Mar 21, 2021

This PR adds some checks on assertion element.
The first commit is not so clean, due to the previous PR that makes some conflicts, please merge the PR previous to this to avoid messes.

checks implemented:

  • assertion version if present MUST be '2.0'
  • NameID Format, if present must be valid
  • SubjectConfirmation Data, InResponseTo and notOnAfter

checks that needs unit test refactor (that's commeted in the code)

  • IssueInstant
  • NameQualifier

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@peppelinux peppelinux changed the title fix: assertion format check fix: assertion format check [WiP] Mar 21, 2021
@c00kiemon5ter c00kiemon5ter marked this pull request as draft April 6, 2021 12:58
@c00kiemon5ter c00kiemon5ter changed the title fix: assertion format check [WiP] Validate assertion format Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant