Skip to content

Format code with black and isort #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Format code with black and isort #873

merged 2 commits into from
Oct 1, 2022

Conversation

c00kiemon5ter
Copy link
Member

@c00kiemon5ter c00kiemon5ter commented Sep 5, 2022

With this changeset the codebase is reformatted to be mostly pep8 compliant. The tools used are black and isort and their configurations are encoded in pyproject.toml as introduced by #872 .

This is the result after running the following commands that automatically reformat the code:

$ poetry run isort src/ tests/ example/
$ poetry run black src/ tests/ example/

and subsequently fixing some of the warning from

$ poetry run flake8 src/

PS: The intention is to make these part of a pre-commit hook and part of the CI checks.

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@c00kiemon5ter c00kiemon5ter force-pushed the feat-format-code branch 2 times, most recently from d3fad4c to 8695fbb Compare October 1, 2022 00:11
@c00kiemon5ter c00kiemon5ter changed the title Draft: Format code with black and isort Format code with black and isort Oct 1, 2022
Base automatically changed from feat-poetry to master October 1, 2022 15:15
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
@c00kiemon5ter c00kiemon5ter merged commit 68dd701 into master Oct 1, 2022
@c00kiemon5ter c00kiemon5ter deleted the feat-format-code branch October 1, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant