Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 4.2 + Fix .swift-version file deprecation #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Chris-Perkins
Copy link

Hi! Thanks for the great library. While using this library in my own project, my project was failing to build due to some cocoapods changes (highlighted below).

This pull request does the following:

  1. Remove the .swift-version file and replace it with a s.swift_version in the Podspec file for the following reason:
    • CocoaPods 1.4.0+ doesn't fully respect .swift-version files like previous installations; installed pods will attempt to be built using your project's explicit swift version.
    • In my case, this was Swift 4.2, and the project failed to build since multiple renames have occurred from Swift 4.0 -> 4.2.
  2. Update the files to be compatible with Swift 4.2 to keep up with Swift's constantly evolving/deprecating nature

This pull request does not do the following:

  • Update the podspec file with a new version number or create any new tags-- you'll have to do this part if this PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant