Better errors on unknown possible-keywords #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [[%s is not a recognized keyword. Likely causes: | ||
| a) %s is a typo, invalid keyword, or similar error. | ||
| b) An attempt to use keyword elision. | ||
| Repeating the previous keyword is not implemented. |
There was a problem hiding this comment.
Looks good to me. Consider rewording to remove the phrase "keyword elision"; it's not something the user is going to understand. i.e. "Probably this is a typo that you should fix. It could be, though, that you are using a shorthand form of pflang in which, for example, 'host a or b' means 'host a or host b'. Pflua doesn't support this shorthand syntax yet; instead, write out the full form, without omitting keywords."
dunno, that was a pretty bad attempt and I'm sure that anything you come up with will be better :)
As raised in #153 This change introduces a clearer and much more verbose error message on similar invalid pflang input.
|
I've reworded it taking that further into account, though I'm not entirely convinced my second attempt is much better than my first one. |
kbara
added a commit
that referenced
this pull request
Apr 14, 2015
Better errors on unknown possible-keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in #153
This change introduces a clearer and much more verbose error message on
similar invalid pflang input.