gstreamer: Include additional patches #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philn
force-pushed
the
gst-1.24-patches
branch
from
8b97c84
to
84396c2
Compare
dpino
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Nitpick: When applying a patch to a git repository, the argument strip is not actually used.
The argument strip is used to compose the command patch -p%d < "%s" (https://gitlab.gnome.org/GNOME/jhbuild/-/blob/master/jhbuild/versioncontrol/tarball.py?ref_type=heads#L239), which is used to apply a patch to a tarball. When the repository is a git repository, patches are applied via git am or git apply without using strip.
In any case, leaving strip doesn't hurt because if someone in the future modifies this repo to a tarball the patches may fail to apply.
philn
force-pushed
the
gst-1.24-patches
branch
from
84396c2
to
1d10061
Compare
|
Thanks Diego, I didn't know about this. |
philn
force-pushed
the
gst-1.24-patches
branch
from
1d10061
to
d7aecbb
Compare
Out of the list only 0009-rtpfunnel-Ensure-segment-events-are-forwarded-after-.patch is going to ship in 1.24(.10). The others will ship in 1.26.
philn
force-pushed
the
gst-1.24-patches
branch
from
d7aecbb
to
b10f917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of the list only
0009-rtpfunnel-Ensure-segment-events-are-forwarded-after-.patch is going to ship in 1.24(.10). The others will ship in 1.26.