Migration to Gecko 128.5.1esr #1658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent backports to the 128.x ESR releases brought changes to the shared memory structures we use for WebXR. Most of them are migrations from C arrays to std::arrays but there are some other changes. Apart from that the structures used in Chromium for hand tracking and AR had to be updated too.
|
I have been testing this version and could not find any regressions so far. HeyVR, Moon Rider, YouTube (regular and immersive), Spotify, DelightXR video player, etc. work well. |
felipeerias
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
@svillar After not finding any regressions, I am tentatively approving this PR. I will continue testing it for some time, just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent backports to the 128.x ESR releases brought changes to the shared memory structures we use for WebXR. Most of them are migrations from C arrays to std::arrays but there are some other changes.
Apart from that the structures used in Chromium for hand tracking and AR had to be updated too.
Fixes #1524