Create New Tab page and add an option to set New Tab page as homepage #1574

haanhvu · 2024-10-15T09:05:14Z

haanhvu · 2024-10-15T09:05:21Z

@felipeerias @svillar (and other maintainers) This is a very draft initial implementation. Currently I just added a Homepage option that shows Bookmarks panel like this: https://drive.google.com/file/d/1feSPqru-LJJOmQ3kwPKKuEXal9dirkbr/view?usp=sharing

I'm thinking of creating a specific New Tab page that shows bookmarks (and maybe other things too?). Do you have any ideas on how that New Tab page should look like? Is there any existing layout that I can use for this page?

svillar · 2024-10-15T11:17:35Z

@felipeerias @svillar (and other maintainers) This is a very draft initial implementation. Currently I just added a Homepage option that shows Bookmarks panel like this: https://drive.google.com/file/d/1feSPqru-LJJOmQ3kwPKKuEXal9dirkbr/view?usp=sharing

I'm thinking of creating a specific New Tab page that shows bookmarks (and maybe other things too?). Do you have any ideas on how that New Tab page should look like? Is there any existing layout that I can use for this page?

I think we should be consistent with what others do. See Desktop Firefox, Chrome, or Edge for inspiration

haanhvu · 2024-11-18T09:42:51Z

@felipeerias @svillar (and other maintainers) There's bug in the New Tab page that I'm not having any clues to debug. Basically, the hovering point is not exactly as it's showing.

For example:

As you can see, the hovering point is outside of the page item, however, somehow the New Tab page sees the point as being inside the page item, and shows the trash icon.

The reverse is true too: when I actually hover in the item, the page doesn't recognize that and doesn't show the trash icon:

Could you help me to debug this? Thanks!

felipeerias

Thank you, this is great work 🙂

In addition to these suggestions, we also need to add the New Page to the WindowViewModel so other elements in the UI are updated correctly.

See WindowViewModel.setIsLibraryVisible() and WindowViewModel.getIsLibraryVisible() for reference.

felipeerias · 2024-11-20T02:53:37Z

app/src/common/shared/com/igalia/wolvic/ui/adapters/Bookmark.java

I think that the changes in this file are not needed for now. I would rather focus this PR on just getting the basic functionality. Let's implement the New Tab content in subsequent PRs.

felipeerias · 2024-11-20T02:54:51Z

app/src/common/shared/com/igalia/wolvic/ui/adapters/NewTabAdapter.java

This is a good idea but let's move it to a separate PR once we land this one.

felipeerias · 2024-11-20T02:55:29Z

app/src/common/shared/com/igalia/wolvic/ui/views/library/BookmarksView.java

@@ -111,6 +111,7 @@ public void updateUI() {
        mBinding.setBookmarksViewModel(mViewModel);
        mBinding.setCallback(mBookmarksCallback);
        mBookmarkAdapter = new BookmarkAdapter(mBookmarkItemCallback, getContext());
+        mBookmarkAdapter = new BookmarkAdapter(mBookmarkItemCallback, getContext());


Duplicated line.

felipeerias · 2024-11-20T03:06:33Z

app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java

+            SettingsStore.getInstance(getContext()).setHomepage(mDefaultHomepageUrl);
+        } else if (checkedId == 1) {
+            mBinding.homepageEdit.setVisibility(View.GONE);
+            SettingsStore.getInstance(getContext()).setHomepage("about://newtab");


Use UrlUtils.isNewTabUrl()

felipeerias · 2024-11-20T03:07:16Z

app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java

+    private int getHomepageId(String homepage) {
+        if (homepage ==  getContext().getString(R.string.HOMEPAGE_URL)) {
+            return 0;
+        } else if (homepage == "about://newtab") {


Use UrlUtils.isNewTabUrl()

felipeerias · 2024-11-20T08:01:56Z

app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java

+        if (mNewTab != null) {
+            setView(mNewTab, true);
+            mViewModel.setIsFindInPage(false);
+            final Runnable firstDrawCallback = mFirstDrawCallback;


I am not sure, but I think that we need to have the same check as in showPanel() below.

if (mRestoreFirstPaint == null && !isFirstPaintReady() && (mFirstDrawCallback != null) && (mSurface != null)) { ...

felipeerias · 2024-11-20T08:03:08Z

app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java

-            if(UrlUtils.isBookmarksUrl(uri.toString())) {
-                showPanel(Windows.BOOKMARKS);
+           if(UrlUtils.isBookmarksUrl(uri.toString())) {
+               hideNewTab(true);


Maybe we can make showPanel(…) hide the New Tab view?

felipeerias · 2024-11-20T08:31:56Z

app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java

+            SettingsStore.getInstance(getContext()).setHomepage(mDefaultHomepageUrl);
+        } else if (checkedId == 1) {
+            mBinding.homepageEdit.setVisibility(View.GONE);
+            SettingsStore.getInstance(getContext()).setHomepage("about://newtab");


Use UrlUtils.ABOUT_NEWTAB.

felipeerias · 2024-11-20T08:32:53Z

app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java

+    }
+
+    private int getHomepageId(String homepage) {
+        if (homepage ==  getContext().getString(R.string.HOMEPAGE_URL)) {


We need to use equals() in Java to compare strings.

felipeerias · 2024-11-20T08:34:08Z

app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java

+    private int getHomepageId(String homepage) {
+        if (homepage ==  getContext().getString(R.string.HOMEPAGE_URL)) {
+            return 0;
+        } else if (homepage == "about://newtab") {


Use equals() and UrlUtils.ABOUT_NEWTAB.

This reverts commit dd638d2.

This reverts commit 63e622f.

This reverts commit 26873c9.

This reverts commit 1c569d5.

This reverts commit e1daefe.

This reverts commit e4d09f7.

…nges that need to be fixed in next commit

haanhvu changed the title ~~Add an option that shows bookmarks in Homepage/New tab~~ Add an option that shows bookmarks as Homepage/New tab Oct 15, 2024

haanhvu force-pushed the issue1318 branch 2 times, most recently from 64fb0d9 to 218b7b8 Compare October 22, 2024 17:51

haanhvu force-pushed the issue1318 branch from 28a4e02 to e3080e9 Compare November 4, 2024 09:35

haanhvu changed the title ~~Add an option that shows bookmarks as Homepage/New tab~~ Create New Tab page and add an option to set New Tab page as homepage Nov 4, 2024

haanhvu force-pushed the issue1318 branch 5 times, most recently from bf3f824 to 8ffd64b Compare November 12, 2024 08:13

haanhvu force-pushed the issue1318 branch 2 times, most recently from 01ac05b to 96768a2 Compare November 18, 2024 06:38

felipeerias requested changes Nov 20, 2024

View reviewed changes

haanhvu and others added 7 commits November 21, 2024 18:07

Create New Tab page and add an option to set New Tab page as homepage

e50e87b

Revert "Upgrade AGP to 8.7.2"

ec62a58

This reverts commit dd638d2.

Revert "Migrate to Gradle v8.9"

37855e0

This reverts commit 63e622f.

Fix bug in adding logic

4f0db1f

Reapply "Migrate to Gradle v8.9"

e4d09f7

This reverts commit 26873c9.

Reapply "Upgrade AGP to 8.7.2"

e1daefe

This reverts commit 1c569d5.

Suggested changes

5574b0c

haanhvu force-pushed the issue1318 branch from 07f5edb to 5574b0c Compare November 21, 2024 11:07

haanhvu added 6 commits November 21, 2024 18:11

Revert "Reapply "Upgrade AGP to 8.7.2""

a74cc24

This reverts commit e1daefe.

Revert "Reapply "Migrate to Gradle v8.9""

bd3c647

This reverts commit e4d09f7.

Enable back button that can go back to New Tab and some redundant cha…

a61e93d

…nges that need to be fixed in next commit

Remove reduntdant changes and enable back to New Tab from library panel

8198bdd

Fix error in back to New Tab

e0c5357

Clean up

3a03026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create New Tab page and add an option to set New Tab page as homepage #1574

Create New Tab page and add an option to set New Tab page as homepage #1574

haanhvu commented Oct 15, 2024

haanhvu commented Oct 15, 2024 •

edited

Loading

svillar commented Oct 15, 2024

haanhvu commented Nov 18, 2024 •

edited

Loading

felipeerias left a comment

felipeerias Nov 20, 2024

felipeerias Nov 20, 2024

felipeerias Nov 20, 2024

felipeerias Nov 20, 2024

felipeerias Nov 20, 2024

felipeerias Nov 20, 2024

felipeerias Nov 20, 2024

felipeerias Nov 20, 2024

felipeerias Nov 20, 2024

felipeerias Nov 20, 2024

Create New Tab page and add an option to set New Tab page as homepage #1574

Are you sure you want to change the base?

Create New Tab page and add an option to set New Tab page as homepage #1574

Conversation

haanhvu commented Oct 15, 2024

haanhvu commented Oct 15, 2024 • edited Loading

svillar commented Oct 15, 2024

haanhvu commented Nov 18, 2024 • edited Loading

felipeerias left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

haanhvu commented Oct 15, 2024 •

edited

Loading

haanhvu commented Nov 18, 2024 •

edited

Loading