Use legacy User-Agent by default, add more settings #440
Conversation
Move the User-Agent settings to the Developer section. Add a new setting to decide whether to use Wolvic's own User-Agent or GeckoView's default one. Add "Mobile" and "Mobile VR" variants to Wolvic's User-Agent, to match what GeckoView does. Update the User-Agent when a page is reloaded. English, Spanish, and Galician translations.
There was a problem hiding this comment.
Looking good, there are a couple of things that I'd like to clarify first.
Also, we talked about showing a dialog warning the user everytime they select a UA which is not the default one (in this case Wolvic's). That information dialog should tell users that enabling Wolvic UI's might break some sites and encourage them to report those missbehaviours. We could talk offline about the exact text to be used.
app/src/common/shared/com/igalia/wolvic/browser/engine/Session.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/browser/engine/Session.java
Outdated
Show resolved
Hide resolved
| public Point getDimensions() { | ||
| return new Point(WidgetPlacement.dpDimension(getContext(), R.dimen.settings_dialog_width), | ||
| WidgetPlacement.dpDimension(getContext(), R.dimen.developer_options_height)); | ||
| } |
There was a problem hiding this comment.
I don't see the relationship of this with anything else.
Is it something that was missing? Does it fix any particular issue? If that's the case it should go in a different PR.
There was a problem hiding this comment.
This makes the dialog a bit taller, which is needed after adding the two settings for the User-Agent.
The alternative was to keep the dialog with the same height, but that looks worse:
| @Override | ||
| protected SettingViewType getType() { | ||
| return SettingViewType.LANGUAGE_VOICE; | ||
| return SettingViewType.DEVELOPER; |
There was a problem hiding this comment.
This is a little issue that I saw when changing the dialog, it seems too small for its own PR but I can open one if needed.
|
We should also check which the exact UA we want to use by default, because DelightXR videos cannot be played unless you append a |
| @@ -76,7 +76,7 @@ public class Session implements WContentBlocking.Delegate, WSession.NavigationDe | |||
| private static UriOverride sDesktopModeOverrides; | |||
| private static final long KEEP_ALIVE_DURATION_MS = 1000; // 1 second. | |||
|
|
|||
| private static final String WOLVIC_USER_AGENT_MOBILE = "Mozilla/5.0 (Android 10; Mobile; rv:105.0) Gecko/105.0 Wolvic/" + BuildConfig.VERSION_NAME; | |||
| private static final String WOLVIC_USER_AGENT_MOBILE = "Mozilla/5.0 (Android 10; Mobile; rv:105.0) Gecko/105.0 Wolvic/" + BuildConfig.VERSION_NAME + " Firefox/105.0 OculusBrowser/25.3.0.4.30.438623098 VR Safari/537.36"; | |||
There was a problem hiding this comment.
Sorry for the back and forth, but it looks like we don't need that.
So we'll stick to the plan of having Gecko/x.x Firefox/x.x by default and then letting users to opt-in to Gecko/x.x Wolvic/x.x in developer options.
There was a problem hiding this comment.
Change reverted. This is how the User-Agent works now:
- Not Wolvic's own UA, VR mode (default):
Mozilla/5.0 (Android 10; Mobile VR; rv:105.0) Gecko/105.0 Firefox/105.0 - Not Wolvic's own UA, Mobile mode:
Mozilla/5.0 (Android 10; Mobile; rv:105.0) Gecko/105.0 Firefox/105.0 - Wolvic's own UA, VR mode:
Mozilla/5.0 (Android 10; Mobile VR; rv:105.0) Gecko/105.0 Wolvic/1.2 - Wolvic's own UA, Mobile mode:
Mozilla/5.0 (Android 10; Mobile; rv:105.0) Gecko/105.0 Wolvic/1.2
|
Also as I mentioned in other comment, we should add some dialog warning the user about enabling Wolvic UA because it might break some sites. |
This reverts commit 55646e1.
|
For reference, this is a related issue in Firefox Reality: MozillaReality/FirefoxReality#478 |
|
I have added an alert dialog when you use Wolvic's own User-Agent:
|
|
Superseeded by #453 |
Our User-Agent by default (when not in Desktop mode) becomes:
This can be modified through the settings:
User-Agent settings have been moved to the Developer section.
Add a new setting to decide whether to use Wolvic's own User-Agent or GeckoView's default one.
Add "Mobile" and "Mobile VR" variants to Wolvic's User-Agent, to match what GeckoView does.
Update the User-Agent when a page is reloaded, so changes to the settings can be effective immediately.
English, Spanish, and Galician translations.