-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace node-sass with dart-sass -vnext #2561
Conversation
src/app/data-entries/select/select-header-footer/select-header-footer.component.scss
Outdated
Show resolved
Hide resolved
…samples into dTsvetkov/replace-node-sass-vnext
…-footer.component.scss Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
After some research i found that, the the sass package on NPM is compiled to JS from Dart, so it has the same behavior as native Dart Sass (unlike the node-sass package, which is based on the deprecated libsass), just with a performance penalty due to running in JS (which shouldn't be a practical issue except for very large projects). |
The issue with the build time increase is also mentioned in angular/components#22676 , angular/angular-cli#20792. |
…samples into dTsvetkov/replace-node-sass-vnext
Closes #2558