Merge pull request #6009 from IgniteUI/nrobakova/fix-issue-5986

Check if grid data is undefined

Author: zdrawku

projects/igniteui-angular/src/lib/grids/grid-common.pipes.ts

@@ -105,7 +105,7 @@ export class IgxGridTransactionPipe implements PipeTransform {
     transform(collection: any[], id: string, pipeTrigger: number) {
         const grid: IgxGridBaseComponent = this.gridAPI.grid;
 
-        if (collection && grid.transactions.enabled) {
+        if ( grid.transactions.enabled) {
             const result = DataUtil.mergeTransactions(
                 cloneArray(collection),
                 grid.transactions.getAggregatedChanges(true),

projects/igniteui-angular/src/lib/grids/grid/grid-summary.spec.ts

@@ -185,7 +185,7 @@ describe('IgxGrid - Summaries #grid', () => {
             fixture.componentInstance.data = undefined;
             fixture.detectChanges();
 
-            expect(grid.data).toEqual(undefined);
+            expect(grid.data).toEqual([]);
             expect(() => {
                 grid.enableSummaries(idColumn.field);
                 fixture.detectChanges();

projects/igniteui-angular/src/lib/grids/grid/grid.component.ts

@@ -136,7 +136,7 @@ export class IgxGridComponent extends IgxGridBaseComponent implements IGridDataB
     }
 
     public set data(value: any[]) {
-        this._data = value;
+        this._data = value || [];
         this.summaryService.clearSummaryCache();
         if (this.shouldGenerate) {
             this.setupColumns();

projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts

@@ -105,7 +105,7 @@ export class IgxGridPagingPipe implements PipeTransform {
             index: page,
             recordsPerPage: perPage
         };
-        DataUtil.correctPagingState(state, collection.data ? collection.data.length : 0);
+        DataUtil.correctPagingState(state, collection.data.length);
 
         const result = {
             data: DataUtil.page(cloneArray(collection.data), state),

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts

@@ -91,7 +91,7 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseCompone
      */
     @Input()
     public set data(value: any[]) {
-        this._data = value;
+        this._data = value || [];
         this.summaryService.clearSummaryCache();
         if (this.shouldGenerate) {
             this.setupColumns();

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.spec.ts

@@ -9,7 +9,8 @@ import {
     IgxTreeGridWrappedInContComponent,
     IgxTreeGridAutoGenerateComponent,
     IgxTreeGridDefaultLoadingComponent,
-    IgxTreeGridCellSelectionComponent
+    IgxTreeGridCellSelectionComponent,
+    IgxTreeGridSummariesTransactionsComponent
 } from '../../test-utils/tree-grid-components.spec';
 import { wait } from '../../test-utils/ui-interactions.spec';
 import { GridSelectionMode } from '../common/enums';
@@ -26,7 +27,8 @@ describe('IgxTreeGrid Component Tests #tGrid', () => {
                 IgxTreeGridWrappedInContComponent,
                 IgxTreeGridAutoGenerateComponent,
                 IgxTreeGridDefaultLoadingComponent,
-                IgxTreeGridCellSelectionComponent
+                IgxTreeGridCellSelectionComponent,
+                IgxTreeGridSummariesTransactionsComponent
             ],
             imports: [
                 NoopAnimationsModule, IgxTreeGridModule]
@@ -205,4 +207,30 @@ describe('IgxTreeGrid Component Tests #tGrid', () => {
 
     });
 
+    describe('Setting null data', () => {
+        it('should not throw error when data is null', () => {
+            let errorMessage = '';
+            fix = TestBed.createComponent(IgxTreeGridCellSelectionComponent);
+            fix.componentInstance.data = null;
+            try {
+                fix.detectChanges();
+            } catch (ex) {
+                errorMessage = ex.message;
+            }
+            expect(errorMessage).toBe('');
+        });
+
+        it('should not throw error when data is null and transactions are enabled', () => {
+            let errorMessage = '';
+            fix = TestBed.createComponent(IgxTreeGridSummariesTransactionsComponent);
+            fix.componentInstance.data = null;
+            try {
+                fix.detectChanges();
+            } catch (ex) {
+                errorMessage = ex.message;
+            }
+            expect(errorMessage).toBe('');
+        });
+    });
+
 });

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts

@@ -102,7 +102,7 @@ export class IgxTreeGridComponent extends IgxGridBaseComponent implements IGridD
     }
 
     public set data(value: any[]) {
-        this._data = value;
+        this._data = value || [];
         this.summaryService.clearSummaryCache();
         if (this.shouldGenerate) {
             this.setupColumns();

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts

@@ -273,7 +273,8 @@ export class IgxTreeGridTransactionPipe implements PipeTransform {
 
     transform(collection: any[], id: string, pipeTrigger: number): any[] {
         const grid: IgxTreeGridComponent = this.gridAPI.grid;
-        if (collection && grid.transactions.enabled) {
+
+        if (grid.transactions.enabled) {
             const aggregatedChanges = grid.transactions.getAggregatedChanges(true);
             if (aggregatedChanges.length > 0) {
                 const primaryKey = grid.primaryKey;
@@ -300,7 +301,6 @@ export class IgxTreeGridTransactionPipe implements PipeTransform {
                 }
             }
         }
-
         return collection;
     }
 }