Skip to content

Check if grid data is undefined #6009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2019
Merged

Check if grid data is undefined #6009

merged 6 commits into from
Oct 21, 2019

Conversation

@nrobakova
Copy link
Contributor

Closes #5986

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@nrobakova nrobakova assigned nrobakova and ddincheva and unassigned nrobakova Oct 18, 2019
@nrobakova nrobakova requested a review from wnvko October 18, 2019 10:31
@nrobakova nrobakova changed the title Check if data is undefined in treeGrid pipes Check if grid data is undefined Oct 18, 2019
wnvko
wnvko reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove check for grid's data in grid-common.pipes.ts also

@wnvko wnvko self-requested a review October 18, 2019 14:19
@ddincheva ddincheva added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 21, 2019
@ddincheva ddincheva added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 21, 2019
@zdrawku zdrawku merged commit d634233 into 8.2.x Oct 21, 2019
@zdrawku zdrawku deleted the nrobakova/fix-issue-5986 branch October 21, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wnvko wnvko wnvko approved these changes

Assignees

@ddincheva ddincheva

Labels

grid: tree-grid version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nrobakova @wnvko @zdrawku @ddincheva