refactor(igx-combo): remove bind, move prop #3243

IgniteUI · Dec 4, 2018 · e7f8808 · e7f8808
1 parent 0c48a10
commit e7f8808
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 16 deletions.
diff --git a/projects/igniteui-angular/src/lib/combo/combo-dropdown.component.ts b/projects/igniteui-angular/src/lib/combo/combo-dropdown.component.ts
@@ -30,11 +30,6 @@ export class IgxComboDropDownComponent extends IgxDropDownBase implements AfterV
         super(elementRef, cdr, selection);
     }
 
-    /**
-     * @hidden
-     */
-    private _vScrollListener = null;
-
     /**
      * @hidden
      */
@@ -57,6 +52,12 @@ export class IgxComboDropDownComponent extends IgxDropDownBase implements AfterV
             this.items.length - 1;
     }
 
+    /**
+     * @hidden
+     * @internal
+     */
+    public disableTransitions = false;
+
     /**
      *  Event emitter overrides
      *
@@ -340,7 +341,7 @@ export class IgxComboDropDownComponent extends IgxDropDownBase implements AfterV
     /**
      * @hidden
      */
-    protected verticalScrollHandler(event) {
+    protected scrollHandler: () => void = () => {
         this.disableTransitions = true;
     }
 
@@ -391,15 +392,14 @@ export class IgxComboDropDownComponent extends IgxDropDownBase implements AfterV
     }
 
     public ngAfterViewInit() {
-        this._vScrollListener = this.verticalScrollHandler.bind(this);
-        this.verticalScrollContainer.getVerticalScroll().addEventListener('scroll', this._vScrollListener);
+        this.verticalScrollContainer.getVerticalScroll().addEventListener('scroll', this.scrollHandler);
     }
 
     /**
      *@hidden
      */
     public ngOnDestroy(): void {
-        this.verticalScrollContainer.getVerticalScroll().removeEventListener('scroll', this._vScrollListener);
+        this.verticalScrollContainer.getVerticalScroll().removeEventListener('scroll', this.scrollHandler);
         this.destroy$.next(true);
         this.destroy$.complete();
     }

diff --git a/projects/igniteui-angular/src/lib/combo/combo-item.component.ts b/projects/igniteui-angular/src/lib/combo/combo-item.component.ts
@@ -8,8 +8,9 @@ import {
     Input
 } from '@angular/core';
 import { IgxSelectionAPIService } from '../core/selection';
-import { IgxDropDownBase, IgxDropDownItemBase } from '../drop-down/drop-down.base';
+import { IgxDropDownItemBase } from '../drop-down/drop-down.base';
 import { IGX_COMBO_COMPONENT, IgxComboBase } from './combo.common';
+import { IgxComboDropDownComponent } from './combo-dropdown.component';
 
 /** @hidden */
 @Component({
@@ -35,7 +36,7 @@ export class IgxComboItemComponent extends IgxDropDownItemBase {
 
     constructor(
         @Inject(IGX_COMBO_COMPONENT) private combo: IgxComboBase,
-        public dropDown: IgxDropDownBase,
+        public dropDown: IgxComboDropDownComponent,
         protected elementRef: ElementRef,
         protected selection: IgxSelectionAPIService
     ) {

diff --git a/projects/igniteui-angular/src/lib/drop-down/drop-down.base.ts b/projects/igniteui-angular/src/lib/drop-down/drop-down.base.ts
@@ -271,11 +271,6 @@ export abstract class IgxDropDownBase implements OnInit, IToggleView {
         return this.elementRef.nativeElement;
     }
 
-    /**
-     * @hidden
-     */
-    public disableTransitions = false;
-
     /**
      * Get dropdown's html element of it scroll container
      */