-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Builder: disabled inputs should be empty #14888
Comments
@sdimchevski |
@teodosiah from a consistency standpoint, users will quickly understand that changing the operator will always reset the input, making the component more predictable. Since consistency and predictability are our top priorities, clearing the input value in all cases (whether for unary or binary operators) offers the simplest and most effective approach. This also simplifies the code by eliminating the need to manage and store previous values. In the future though, we could consider adding a warning to help mitigate the risk of data loss. |
@sdimchevski I have a working solution to this issue, which I'll be happy to share. My question beforehand is, from you perspective which is the best presentation of a disabled field? (Or maybe suggest something else): Thank you P.S. |
@ivanvpetrov I'm concerned about complexity or causing confusion, that's why I suggested a simpler, more predictable approach but you may be right - users who frequently switch between unary and binary operators might find it annoying to re-enter their value, especially if they’re experimenting with different operators to build or refine queries. |
Issue
Steps to reproduce
Result
The "Value" input text still says 123.
Expected result
The input text from "Value" input should be removed and the input should be empty.
Originally posted by @imincheva in #14647 (comment)
The text was updated successfully, but these errors were encountered: