Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(query-builder) Disabled search value input for unary operator #15011

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivanvpetrov
Copy link
Contributor

@ivanvpetrov ivanvpetrov commented Nov 5, 2024

Closes #14888

This solution adds a dedicated empty disabled input field, which is displayed when there is a need to display a disabled input.
This way, when an unary operator is selected, an empty disabled input is displayed and the original input(containing the search value) is been hidden.
Now if the user returns to a non-unary operator, in the context of the same condition editing session, the input appears enabled again still containing the value before the disabling.
If the user saves the unary condition, the search value is only now cleared and won't reappear if opened for edit again and operator changed to not-unary.

P.S. Following the same approach, the input can be removed all together (rather than substituted with a disabled one)
or the placeholder of the disabled input can be changed to 'n/a', -Empty-, or something else.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Builder: disabled inputs should be empty
2 participants