Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igx-grid - Potential memory leak. There are event listeners that are not removed as expected. #3033

Closed
tkiryu opened this issue Nov 19, 2018 · 0 comments
Closed

igx-grid - Potential memory leak. There are event listeners that are not removed as expected. #3033

tkiryu opened this issue Nov 19, 2018 · 0 comments
Assignees
@mpavlinov @PavlovVasil
Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: general ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@tkiryu
Copy link

tkiryu commented Nov 19, 2018 •
edited
Loading

Description

Some event listeners on igx-grid don't be removed as expected. So, it causes memory leak.

  • igniteui-angular version: 6.2.0
  • browser: N/A

Steps to reproduce.

Here is the addEventListeners that have problem.
https://github.com/IgniteUI/igniteui-angular/blob/master/projects/igniteui-angular/src/lib/grids/grid-base.component.ts#L2146
https://github.com/IgniteUI/igniteui-angular/blob/master/projects/igniteui-angular/src/lib/grids/grid-base.component.ts#L2192
https://github.com/IgniteUI/igniteui-angular/blob/master/projects/igniteui-angular/src/lib/grids/grid-base.component.ts#L2196
https://github.com/IgniteUI/igniteui-angular/blob/master/projects/igniteui-angular/src/lib/grids/grid-base.component.ts#L2213
https://github.com/IgniteUI/igniteui-angular/blob/master/projects/igniteui-angular/src/lib/grids/grid-base.component.ts#L4306

Result

These event listeners are added with bind().

Expected result

They should be implemented like this.
https://stackoverflow.com/questions/11565471/removing-event-listener-which-was-added-with-bind#answer-22870717
@mpavlinov mpavlinov assigned dkamburov and PavlovVasil and unassigned zdrawku and dkamburov Nov 19, 2018
@PavlovVasil PavlovVasil added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Nov 20, 2018
PavlovVasil added a commit that referenced this issue Nov 23, 2018
@PavlovVasil
fix(igxGrid): preventing a potential memory leak #3033
6d895e7
PavlovVasil added a commit that referenced this issue Nov 23, 2018
@PavlovVasil
fix(igxGrid): preventing a potential memory leak #3033
2753580
This was referenced Nov 23, 2018
Merged
Merged
@PavlovVasil PavlovVasil added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 23, 2018
PavlovVasil added a commit that referenced this issue Nov 23, 2018
@PavlovVasil
fix(igxGrid): fixing variable names #3033
cae3c36
PavlovVasil added a commit that referenced this issue Nov 23, 2018
@PavlovVasil
fix(igxGrid): fixing variable names #3033
3e66b68
PavlovVasil added a commit that referenced this issue Nov 26, 2018
@PavlovVasil
fix(igxGrid): fixing reference to bound function #3033
77e3f5b
PavlovVasil added a commit that referenced this issue Nov 26, 2018
@PavlovVasil
fix(igxGrid): fixing reference to bound function #3033
538456e
PavlovVasil added a commit that referenced this issue Nov 27, 2018
@PavlovVasil
fix(igxGrid): fixing the wheel listener #3033
2dafe1e
PavlovVasil added a commit that referenced this issue Nov 27, 2018
@PavlovVasil
fix(igxGrid): fixing the wheel listener #3033
8bc2e9f
kdinev added a commit that referenced this issue Nov 28, 2018
@kdinev
Merge pull request #3132 from IgniteUI/vpavlov/fix-3033-6.2.x
37ad506 
Preventing a memory leak  #3033 - 6.2.x
kdinev added a commit that referenced this issue Nov 28, 2018
@kdinev
Merge pull request #3134 from IgniteUI/vpavlov/fix-3033-master
4c855d5 
Preventing a memory leak #3033 - master
@kdinev kdinev closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpavlinov mpavlinov

@PavlovVasil PavlovVasil

Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: general ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@dkamburov @kdinev @mpavlinov @zdrawku @tkiryu @PavlovVasil @SlavUI