Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter row does not close when click button cancel, if the entered text is deleted #3198

Closed
nrobakova opened this issue Nov 28, 2018 · 0 comments
Closed

Filter row does not close when click button cancel, if the entered text is deleted #3198

nrobakova opened this issue Nov 28, 2018 · 0 comments
Assignees
@sstoyanovIG
Labels
🐛 bug Any issue that describes a bug filtering grid: general severity: low version: 6.2.x version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@nrobakova
Copy link
Contributor

Description

Filter row does not close when click button cancel, if the entered text is deleted

  • igniteui-angular version: 7.0.x
  • browser: N/A

Steps to reproduce

  1. Open dev sample gridColumnMoving
  2. Open filter row for column ContactName
  3. In the input type some text
  4. Click on X button to delete typed value
  5. Click on button Cancel

If I click again on Cancel button the filter row is closed

Result

Filter row is not closed

Expected result

Filter row should be closed

Attachments

Attach a sample if available, and screenshots, if applicable.
@sstoyanovIG sstoyanovIG added 🛠️ status: in-development Issues and PRs with active development on them severity: low labels Nov 28, 2018
sstoyanovIG added a commit that referenced this issue Nov 28, 2018
@sstoyanovIG
fix(igx-grid): Pop empty item from expressionsList, #3198
b6d4f76
@sstoyanovIG sstoyanovIG mentioned this issue Nov 28, 2018
Merged
14 tasks
sstoyanovIG added a commit that referenced this issue Nov 28, 2018
@sstoyanovIG
fix(igx-grid): Pop empty item from expressionsList, #3198
aa434e5
@sstoyanovIG sstoyanovIG mentioned this issue Nov 28, 2018
Merged
14 tasks
@sstoyanovIG sstoyanovIG added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 28, 2018
sstoyanovIG added a commit that referenced this issue Nov 28, 2018
@sstoyanovIG
test(igx-grid): Refactor failing test, #3198
8a5d4fc
sstoyanovIG added a commit that referenced this issue Nov 28, 2018
@sstoyanovIG
chore(igx-grid): Refactor failing test, #3198
2358994
kdinev referenced this issue Nov 28, 2018
@kdinev
Merge branch '7.0.x' into sstoyanov/bug-fix-#3198
cddd88c
kdinev referenced this issue Nov 28, 2018
@kdinev
Merge pull request #3213 from IgniteUI/sstoyanov/bug-fix-#3198
79bec52 
Pop empty item from expressionsList
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sstoyanovIG sstoyanovIG

Labels
🐛 bug Any issue that describes a bug filtering grid: general severity: low version: 6.2.x version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrobakova @sstoyanovIG