Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering Row covers the first row of igxGrid when it is dynamically activated and Multi Column Headers are used #3290

Closed
npaunov opened this issue Dec 4, 2018 · 0 comments · Fixed by #3320
Assignees
Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: general grid: multi-column-headers version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@npaunov
Copy link
Contributor

npaunov commented Dec 4, 2018

Description

Filtering Row covers the first row of igxGrid when it is dynamically activated and Multi Column Headers are used

  • igniteui-angular version: 7.0.x
  • browser: all

Steps to reproduce

  1. Open dev demos and go to grid-column-groups.sample.html
  2. Remove [allowFiltering]="true" .
  3. Add button :
<button type="button" (click)="setFilter()">Set Filtering</button>
  1. Add handler in typescript:
    setFilter() {
        this.grid.allowFiltering = !this.grid.allowFiltering;
        this.grid.cdr.markForCheck();
      }
  1. Run the demos and click the button.
  2. Click filter chip.

Result

  1. The filtering row appears over the first grid row.
  2. The filtering UI appears above the filtering row.

Expected result

  1. The filtering row should push down the first grid row.
  2. The filtering UI should replace the filtering row.

Note: everything works as expected if there are no Multi Column Headers used.

Attachments

filteringtest

@SAndreeva SAndreeva added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Dec 5, 2018
SAndreeva added a commit that referenced this issue Dec 5, 2018
…ally #3290

# Conflicts:
#	projects/igniteui-angular/src/lib/grids/grid-base.component.ts
#	projects/igniteui-angular/src/lib/grids/grid/grid-filtering-ui.spec.ts
@SAndreeva SAndreeva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 5, 2018
rkaraivanov pushed a commit that referenced this issue Dec 6, 2018
…namically (#3321)

* fix(grid): recalculate grid body when changing allowFiltering dynamically #3290

* chore(*): try prevent a test from flickering #3290

* fix(grid): address review comments #3290
rkaraivanov pushed a commit that referenced this issue Dec 6, 2018
…namically (#3320)

* fix(grid): recalculate grid body when changing allowFiltering dynamically #3290

* fix(grid): address review comments #3290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: general grid: multi-column-headers version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
4 participants