Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grid): recalculate grid body size when changing allowFiltering dynamically #3321

Merged
merged 4 commits into from
Dec 6, 2018
Merged

fix(grid): recalculate grid body size when changing allowFiltering dynamically #3321

merged 4 commits into from
Dec 6, 2018

Conversation

SAndreeva
Copy link
Contributor

Closes #3290

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@SAndreeva
fix(grid): recalculate grid body when changing allowFiltering dynamic…
c7f0d43 
…ally #3290

# Conflicts:
#	projects/igniteui-angular/src/lib/grids/grid-base.component.ts
#	projects/igniteui-angular/src/lib/grids/grid/grid-filtering-ui.spec.ts
@SAndreeva
chore(*): try prevent a test from flickering #3290
6d764d4
@SAndreeva SAndreeva added 🐛 bug Any issue that describes a bug ❌ status: awaiting-test PRs awaiting manual verification grid: general version: 7.0.x labels Dec 5, 2018
@npaunov npaunov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 5, 2018
@rkaraivanov rkaraivanov merged commit 20c1feb into 7.0.x Dec 6, 2018
@rkaraivanov rkaraivanov deleted the SAndreeva/fix-bug-3290-7.0.x branch December 6, 2018 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstoyanovIG sstoyanovIG sstoyanovIG approved these changes

@bkulov bkulov bkulov approved these changes

Assignees

@npaunov npaunov

Labels
🐛 bug Any issue that describes a bug grid: general version: 7.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SAndreeva @bkulov @sstoyanovIG @npaunov @rkaraivanov