Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Row editing overlay is not visible when grid has either 1 or 2 rows and height is not set. #4240

Closed
skrustev opened this issue Mar 8, 2019 · 0 comments · Fixed by #4501
Closed

Row editing overlay is not visible when grid has either 1 or 2 rows and height is not set. #4240

skrustev opened this issue Mar 8, 2019 · 0 comments · Fixed by #4501
Assignees
@Lipata @bazal4o
Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: row-editing version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@skrustev
Copy link
Member

skrustev commented Mar 8, 2019 •
edited
Loading

Description

When grid is rendered with now height set and the data has only 1/2 rows and when the first row is row edit mode the overlay containing the Done/Cancel buttons is not visible.

  • igniteui-angular version: 7.1.x
  • browser: All

Steps to reproduce

  1. Open the Grid Row Editing demo.
  2. Remove the height property of the first grid and set the data to 1 or 2 rows.
  3. Try to edit the first row.

Result

The Done/Cancel overlay is not visible to the user.

Expected result

The Done/Cancel overlay should be visible.

Attachments

row-editing-1
row-editing-2
@Lipata Lipata self-assigned this Mar 12, 2019
@Lipata Lipata added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 21, 2019
Lipata added a commit that referenced this issue Mar 21, 2019
@Lipata
fix(grid): outlet outside body when 1-2 rows #4240
6e87bf9
@Lipata Lipata mentioned this issue Mar 21, 2019
Merged
14 tasks
Lipata added a commit that referenced this issue Mar 27, 2019
@Lipata
fix(grid): use parent grid outlet #4240
727d4f8
@Lipata Lipata added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them version: 7.1.x labels Mar 27, 2019
Lipata added a commit that referenced this issue Apr 9, 2019
@Lipata
fix(grid): hgrid parent container = null #4240
58caa61
Lipata added a commit that referenced this issue Apr 9, 2019
@Lipata
docs(grid): hide method #4240
edd2132
Lipata added a commit that referenced this issue Apr 10, 2019
@Lipata
docs(grid): add comment for the fix #4240
cfddca2
Lipata added a commit that referenced this issue Apr 10, 2019
@Lipata
refactor(grid): create const #4240
181704a
@kdinev kdinev mentioned this issue Apr 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@bazal4o bazal4o

Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: row-editing version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merging 7.2.x into master IgniteUI/igniteui-angular
3 participants
@Lipata @skrustev @bazal4o