Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column Moving keydown.escape HostListener needs refactoring #4296

Closed
SAndreeva opened this issue Mar 13, 2019 · 0 comments
Closed

Column Moving keydown.escape HostListener needs refactoring #4296

SAndreeva opened this issue Mar 13, 2019 · 0 comments
Assignees
@bkulov @SAndreeva
Labels
📈 enhancement 🧨 severity: medium grid: column-moving grid: general version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@SAndreeva
Copy link
Contributor

Description

IgxColumnMovingDragDirective should not have a HostListener for keydown.escape on the document object, as the directive is applied on each header.

  • igniteui-angular version: 7.2.x
  • browser: all
@SAndreeva SAndreeva self-assigned this Mar 13, 2019
@SAndreeva SAndreeva added the 🛠️ status: in-development Issues and PRs with active development on them label Mar 13, 2019
SAndreeva added a commit that referenced this issue Mar 13, 2019
@SAndreeva
refactor(column moving): escape functionality #4296
e9336e6
@SAndreeva SAndreeva mentioned this issue Mar 13, 2019
Merged
14 tasks
@SAndreeva SAndreeva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 13, 2019
SAndreeva added a commit that referenced this issue Mar 13, 2019
@SAndreeva
chore(*): address review comments #4296
53f97c6
SAndreeva added a commit that referenced this issue Apr 4, 2019
@SAndreeva
fix(*): build error #4296
d6966b5
bkulov pushed a commit that referenced this issue Apr 4, 2019
@SAndreeva @bkulov
grid: refactor column moving keydown.escape HostListener (#4301)
ef844c3 
* refactor(column moving): escape functionality #4296

* chore(*): address review comments #4296

* fix(*): build error #4296
This was referenced Apr 4, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkulov bkulov

@SAndreeva SAndreeva

Labels
📈 enhancement 🧨 severity: medium grid: column-moving grid: general version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkulov @SAndreeva