Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[igx-grid][IE11] filtering problems with IME mode. #4636

Closed
tkiryu opened this issue Apr 24, 2019 · 4 comments · Fixed by #4783
Closed

[igx-grid][IE11] filtering problems with IME mode. #4636

tkiryu opened this issue Apr 24, 2019 · 4 comments · Fixed by #4783
Assignees
Labels
browser: IE-11 Issues specific to the MS IE11 browser 🐛 bug Any issue that describes a bug filtering 🧨 severity: medium ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@tkiryu
Copy link

tkiryu commented Apr 24, 2019

Description

When typing with IME mode in the filter textbox, some problems with filtering happens on IE11.

  • igniteui-angular version: 7.2.6
  • browser: IE11

Steps to reproduce

  1. Run the attached sample on IE11.
  2. Click a filter chip on the column "1".
  3. Focus in the filter textbox.
  4. Enable IME.
  5. Type "ha" quickly, which is coverted to "は", in the filter textbox.
  6. Type "hi" quickly, which is coverted to "ひ", in the filter textbox.
  7. Type "fu" quickly, which is coverted to "ふ", in the filter textbox.

Result

There are two problems.

  1. The result of filtering is not correct. Because "hahifu" is converted to "はひふ" and matches one row.
  2. Filtering chip text is not updated correctly. (You can reproduce it on online sample as well)
    • textbox: "は" <-> chip text: "h"
    • textbox: "はひ" <-> chip text: "はh"
    • textbox: "はひふ" <-> chip text: "はひf"

issue

Expected result

  1. The result of filtering should be one row.
  2. Filtering chip text should updated correctly.
    • textbox: "は" <-> chip text: "は"
    • textbox: "はひ" <-> chip text: "はひ"
    • textbox: "はひふ" <-> chip text: "はひふ"

In fact, when typing slowly, the problems don't happen.

expected result

Attachments

igx-grid-filtering-issue.zip

@tkiryu tkiryu added the 🐛 bug Any issue that describes a bug label Apr 24, 2019
@SlavUI SlavUI assigned gedinakova and SlavUI and unassigned SlavUI Apr 24, 2019
@gedinakova gedinakova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels May 10, 2019
@gedinakova gedinakova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels May 10, 2019
@gedinakova
Copy link
Contributor

@tkiryu Tatsushi, can you, please, test one of the pull requests and confirm the issue is gone, because I wasn't able to very stably reproduce it at my end even before the fix, so I will appreciate it if you can double check the fix for me?

@tkiryu
Copy link
Author

tkiryu commented May 13, 2019

@gedinakova , OK, I will do that!

@tkiryu
Copy link
Author

tkiryu commented May 13, 2019

@gedinakova , I tested it. The fix in itself seemed to work well for this issue.

By the way, when I close the filtering row, an error happened.
Here is a stacktrace.

"Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges
at debugUpdateDirectives (http://localhost:4200/vendor.js:65903:9)
at checkAndUpdateView (http://localhost:4200/vendor.js:65302:5)
at callWithDebugContext (http://localhost:4200/vendor.js:66172:9)
at debugCheckAndUpdateView (http://localhost:4200/vendor.js:65874:5)
at ViewRef_.prototype.detectChanges (http://localhost:4200/vendor.js:63683:13)
at Anonymous function (http://localhost:4200/vendor.js:139161:13)
at ZoneDelegate.prototype.invokeTask (http://localhost:4200/polyfills.js:3113:13)
at onInvokeTask (http://localhost:4200/vendor.js:59285:17)
at ZoneDelegate.prototype.invokeTask (http://localhost:4200/polyfills.js:3113:13)
at Zone.prototype.runTask (http://localhost:4200/polyfills.js:2886:21)"

error-when-closing-filtering-row

I'll log it as an another issue. If you know anything about it, please let me know.

Anyway, I think the fix is OK!. Thanks!

@tkiryu
Copy link
Author

tkiryu commented May 13, 2019

@gedinakova , FYI, #4764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: IE-11 Issues specific to the MS IE11 browser 🐛 bug Any issue that describes a bug filtering 🧨 severity: medium ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants