Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use browser locale when locale is not explicitly set #799

Closed
StefanIvanov opened this issue Mar 21, 2018 · 0 comments
Closed

Use browser locale when locale is not explicitly set #799

StefanIvanov opened this issue Mar 21, 2018 · 0 comments
Assignees
Labels
📆 calendar 📈 enhancement 🕐 time-picker severity: low 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@StefanIvanov
Copy link
Contributor

Description

When a locale is not explicitly set our components use the "en" locale, rather than checking for the browser locale and using it instead of the "en" one

Steps to reproduce

  1. Create a calendar
  2. Don't set an option for locale
  3. Calendar shows with "en" locale

Result

"en" locale is used whenever the developer has not set a locale explicitly

Expected result

If no locale is set, the control should try to use the browser locale and only if this fails for some reason the locale should be set to "en"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📆 calendar 📈 enhancement 🕐 time-picker severity: low 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants