Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locale property to igx-grid #3487

Closed
wants to merge 5 commits into from
Closed

Add locale property to igx-grid #3487

wants to merge 5 commits into from

Conversation

sstoyanovIG
Copy link
Contributor

Closes #3455, Closes #799

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@sstoyanovIG
feat(igx-grid): Add locale property to igx-grid, #3455
d3e42e5 
# Conflicts:
#	CHANGELOG.md
#	projects/igniteui-angular/src/lib/grids/README.md
@npaunov npaunov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Dec 19, 2018
@npaunov npaunov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Dec 20, 2018
@npaunov
Copy link
Contributor

npaunov commented Dec 20, 2018 •
edited
Loading

Consider the following scenario:
The igxGrid is included in new app. The grid contains date and/or number columns. If the app is opened in any browser with language not set to English, the data in those columns will not be shown and cells rendering will break on scrolling horizontally.
The reason for this behavior is that the angular localized strings (e.g. @angular/common/locales/fr) for this particular language are not included in the app.

@mpavlinov mpavlinov assigned SAndreeva and unassigned npaunov Jan 3, 2019
@sstoyanovIG sstoyanovIG closed this Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChronosSF ChronosSF ChronosSF approved these changes

@bkulov bkulov Awaiting requested review from bkulov

@rkaraivanov rkaraivanov Awaiting requested review from rkaraivanov

Assignees

@SAndreeva SAndreeva

Labels
📆 calendar 📅 date-picker grid: general version: 7.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request : locale property on a grid level Use browser locale when locale is not explicitly set
5 participants
@sstoyanovIG @npaunov @ChronosSF @SAndreeva @mpavlinov