Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trap focus inside modal #10383

Merged
merged 38 commits into from
Nov 9, 2021
Merged

Trap focus inside modal #10383

merged 38 commits into from
Nov 9, 2021

Conversation

PlamenaMiteva
Copy link
Contributor

Closes #8961

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@PlamenaMiteva PlamenaMiteva requested a review from Lipata October 27, 2021 18:00
@Lipata Lipata requested a review from wnvko November 1, 2021 08:38
@wnvko wnvko added the ❌ status: awaiting-test PRs awaiting manual verification label Nov 1, 2021
@PlamenaMiteva PlamenaMiteva requested a review from wnvko November 3, 2021 11:12
@PlamenaMiteva PlamenaMiteva requested a review from wnvko November 4, 2021 10:55
wnvko
wnvko previously approved these changes Nov 4, 2021
View reviewed changes
Lipata
Lipata requested changes Nov 4, 2021
View reviewed changes
Copy link
Member

@Lipata Lipata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog bullet, readme file for the new directive and update the general readme.

@wnvko wnvko self-requested a review November 5, 2021 09:11
@wnvko wnvko added the 💥 status: in-test PRs currently being tested label Nov 8, 2021
@wnvko wnvko added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 8, 2021
@wnvko wnvko self-requested a review November 8, 2021 10:18
wnvko
wnvko previously approved these changes Nov 8, 2021
View reviewed changes
@wnvko wnvko removed their assignment Nov 8, 2021
@Lipata Lipata requested a review from wnvko November 9, 2021 11:01
Lipata
Lipata previously approved these changes Nov 9, 2021
View reviewed changes
@Lipata Lipata merged commit e1ca089 into master Nov 9, 2021
@Lipata Lipata deleted the PMiteva/overlay-focus branch November 9, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnvko wnvko wnvko approved these changes

@Lipata Lipata Lipata approved these changes

Assignees
No one assigned
Labels
overlay version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep focus inside igxOverlay
3 participants
@PlamenaMiteva @wnvko @Lipata