-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pivot data selector #10736
Add pivot data selector #10736
Conversation
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm only adding few minor comments.
projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-data-selector.component.ts
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-data-selector.component.ts
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-data-selector.component.html
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-data-selector.component.ts
Outdated
Show resolved
Hide resolved
|
||
const dimension = this.getDimensionsByType(dimensionType); | ||
const dimensionState = this.getDimensionState(dimensionType); | ||
const itemId = event.drag.element.nativeElement.id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the IgxDrag/IgxDrop data
property to store the element ID as well like the panel type on dropped instead of accessing the native element.
PS: Might help with the dragging of chips between pivot data selector and drop areas inside the pivot grid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already use the data property on the Drag directive for other purposes. Also, we've decided that we don't want to drag elements between the grid and the pivot data selector.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)