Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pivot data selector #10736

Merged
merged 78 commits into from
Feb 17, 2022
Merged

Add pivot data selector #10736

merged 78 commits into from
Feb 17, 2022

Conversation

simeonoff
Copy link
Collaborator

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Base automatically changed from pivot-grid-master to master February 1, 2022 11:28
@3phase
Copy link
Contributor

3phase commented Feb 16, 2022

Edit: both of the issues that were logged by me, are logged separately (#11050 and #11051).

The IPivotConfiguration does not require the filters-property and defaults to null if it's not present, so the case when there's no filters in the configuration should be handled in order to avoid the error below.

image

@3phase
Copy link
Contributor

3phase commented Feb 16, 2022

When trying to drag and drop chips, the viewport would scroll down and eventually hide all contents above the grid. In the particular sample scenario, it's the navbar on top of page, making it unable to revive.
Edit: might be similar to the third issue that Maya has logged

pivot-issue-10

Copy link
Contributor

@dkamburov dkamburov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm only adding few minor comments.

ChronosSF
ChronosSF previously approved these changes Feb 16, 2022

const dimension = this.getDimensionsByType(dimensionType);
const dimensionState = this.getDimensionState(dimensionType);
const itemId = event.drag.element.nativeElement.id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the IgxDrag/IgxDrop data property to store the element ID as well like the panel type on dropped instead of accessing the native element.

PS: Might help with the dragging of chips between pivot data selector and drop areas inside the pivot grid

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already use the data property on the Drag directive for other purposes. Also, we've decided that we don't want to drag elements between the grid and the pivot data selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: pivot status: localized version: 13.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants