Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grids): refactor cell width #13460

Merged
merged 10 commits into from
Oct 9, 2023
Merged

fix(grids): refactor cell width #13460

merged 10 commits into from
Oct 9, 2023

Conversation

ddaribo
Copy link
Contributor

@ddaribo ddaribo commented Sep 13, 2023

Closes #13452

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddaribo ddaribo force-pushed the bpachilova/fix-13452 branch 2 times, most recently from f225fe5 to e8174e6 Compare September 14, 2023 07:58
dkamburov
dkamburov previously approved these changes Sep 27, 2023
@dkamburov dkamburov marked this pull request as ready for review September 27, 2023 11:04
@ddaribo ddaribo added the ❌ status: awaiting-test PRs awaiting manual verification label Sep 27, 2023
@RivaIvanova RivaIvanova self-assigned this Sep 28, 2023
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 28, 2023
@RivaIvanova
Copy link
Member

If I have an IgxGrid with the following configuration:

<igx-grid #grid [height]="'500px'" [width]="'1000px'" [data]="data">
    <igx-column field="ID" [width]="'10%'"></igx-column>
    <igx-column field="CompanyName" [width]="'25%'"></igx-column>
    <igx-column field="ContactName" [width]="'20%'"></igx-column>
    <igx-column field="ContactTitle" [width]="'25%'"></igx-column>
    <igx-column field="Country" [width]="'10%'"></igx-column>
    <igx-column field="Region" [width]="'10%'"></igx-column>
</igx-grid>

and enough data records in order for the vertical scrollbar to be displayed, the cell is misaligned.
cell-misalignment

The cell has width equal to 98px, however, the header is 98.3px.

This is reproducible when the width is set in percentage, when set in px or auto there is no misalignment.

@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Sep 28, 2023
@ddaribo ddaribo added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 29, 2023
@ddaribo ddaribo requested a review from dkamburov October 2, 2023 08:31
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 4, 2023
@ChronosSF ChronosSF changed the base branch from master to 16.1.x October 4, 2023 13:11
@RivaIvanova RivaIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 4, 2023
@dkamburov dkamburov merged commit d20bd86 into 16.1.x Oct 9, 2023
5 checks passed
@dkamburov dkamburov deleted the bpachilova/fix-13452 branch October 9, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid version: 16.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid cells misalignment when there are Multi-column headers' child columns with % width
4 participants