Skip to content

build(sass): switch from gulp-sass to sass-embedded #13517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 10, 2023
Merged

build(sass): switch from gulp-sass to sass-embedded #13517

merged 8 commits into from
Oct 10, 2023

Conversation

@simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Oct 2, 2023 •
edited
Loading

Closes #13515

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff added 🧱 ci: build CI build related issues and PRs ❌ status: awaiting-test PRs awaiting manual verification ✨ themes version: 16.1.x labels Oct 2, 2023
@simeonoff simeonoff requested a review from kdinev October 2, 2023 16:40
kdinev
kdinev previously approved these changes Oct 3, 2023
View reviewed changes
@kdinev kdinev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 3, 2023
@kdinev
Copy link
Member

kdinev commented Oct 3, 2023 •
edited
Loading

@simeonoff This is significantly faster! You're helping save the environment! :)

image

You should propagate the change to 16.0.x and 15.1.x if possible.

@simeonoff
Copy link
Collaborator Author

simeonoff commented Oct 3, 2023

@simeonoff This is significantly faster! You're helping save the environment! :)

image

You should propagate the change to 16.0.x and 15.1.x if possible.

Roger, will do.

Can't take all the credit for it as it's mainly the power of sass-embedded being utilized here.

@ChronosSF ChronosSF changed the base branch from master to 16.1.x October 4, 2023 13:11
@simeonoff simeonoff requested a review from kdinev October 6, 2023 07:40
@kdinev kdinev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 10, 2023
@kdinev kdinev merged commit 3fd292c into 16.1.x Oct 10, 2023
@kdinev kdinev deleted the simeonoff/sass-build branch October 10, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdinev kdinev kdinev approved these changes

Assignees

@kdinev kdinev

Labels

🧱 ci: build CI build related issues and PRs ✨ themes version: 16.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

buildStyles step of the build takes a long time to complete

3 participants

@simeonoff @kdinev