Update selection changing events #13619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wnvko
added
❌ status: awaiting-test
valadzhov
added
💥 status: in-test
kdinev
previously approved these changes
Nov 6, 2023
…bo-selection-change-event-update
kdinev
previously approved these changes
Nov 6, 2023
valadzhov
added
✅ status: verified
damyanpetev
requested changes
Nov 6, 2023
projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Damyan Petev <damyanpetev@users.noreply.github.com>
Co-authored-by: Damyan Petev <damyanpetev@users.noreply.github.com>
Co-authored-by: Damyan Petev <damyanpetev@users.noreply.github.com>
|
This is the result when setting the |
valadzhov
added
✅ status: verified
damyanpetev
previously approved these changes
Nov 6, 2023
…/github.com/IgniteUI/igniteui-angular into mvenkov/combo-selection-change-event-update
this should not be supported. |
|
@wnvko , please fix the conflict |
kdinev
previously approved these changes
Nov 7, 2023
…bo-selection-change-event-update
damyanpetev
reviewed
Nov 7, 2023
| ]; | ||
|
|
||
| fixture.componentInstance.reactiveForm.resetForm(); | ||
| fixture.detectChanges(); | ||
|
|
||
| expect(combo.displayValue).toEqual([]); |
There was a problem hiding this comment.
👀 I see we have our work cut out for us
damyanpetev
reviewed
Nov 7, 2023
projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.spec.ts
Show resolved
Hide resolved
damyanpetev
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
oldSelectionandnewSelectionproperties of both combos selection changing arguments tooldValueandnewValue. Also addoldSelectionandnewSelectionwhich should always emit the entire selected items.Also fixes disappearing combo items in the input string when combo is bound to remote data.
Closes #13595
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)