Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simple-combo): value & selection correct single type instead array #13647

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

damyanpetev
Copy link
Member

Corrects changes made for #13089

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

kdinev
kdinev previously approved these changes Nov 8, 2023
@damyanpetev damyanpetev force-pushed the dpetev/simple-combo-value-selection branch from e42ecf6 to deff69b Compare November 8, 2023 08:27
@damyanpetev damyanpetev requested a review from kdinev November 8, 2023 08:27
@Lipata Lipata added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 8, 2023
@Lipata Lipata added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 8, 2023
@Lipata Lipata merged commit 015a41d into master Nov 8, 2023
4 of 5 checks passed
@Lipata Lipata deleted the dpetev/simple-combo-value-selection branch November 8, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants